fix: publication decorator should not return unpublished columns

packages/datasource-toolkit/src/decorators/publication/collection.ts

@@ -1,4 +1,6 @@
+import { Caller } from '../../interfaces/caller';
 import { CollectionSchema, FieldSchema } from '../../interfaces/schema';
+import { RecordData } from '../../interfaces/record';
 import CollectionDecorator from '../collection-decorator';
 import DataSourceDecorator from '../datasource-decorator';
 
@@ -24,6 +26,18 @@ export default class PublicationCollectionDecorator extends CollectionDecorator
     this.markSchemaAsDirty();
   }
 
+  override async create(caller: Caller, data: RecordData[]): Promise<RecordData[]> {
+    const records = await super.create(caller, data);
+
+    return records.map(childRecord => {
+      const record = {};
+      for (const key of Object.keys(childRecord))
+        if (!this.unpublished.has(key)) record[key] = childRecord[key];
+
+      return record;
+    });
+  }
+
   protected override refineSchema(childSchema: CollectionSchema): CollectionSchema {
     const fields: Record<string, FieldSchema> = {};
 

packages/datasource-toolkit/test/decorators/publication/collection.test.ts

@@ -126,6 +126,14 @@ describe('PublicationCollectionDecorator', () => {
       expect(newPersons.schema).toStrictEqual(persons.schema);
       expect(newBooks.schema).toStrictEqual(books.schema);
     });
+
+    test('create should proxies return value (removing extra columns)', async () => {
+      const created = { id: 1, bookId: 2, personId: 3, date: '1985-10-26' };
+      (bookPersons.create as jest.Mock).mockResolvedValue([created]);
+
+      const result = await newBookPersons.create(null, [{ something: true }]);
+      expect(result).toStrictEqual([{ id: 1, bookId: 2, personId: 3 }]);
+    });
   });
 
   describe('When hiding foreign keys', () => {