Skip to content

chore: create firebase package directory#332

Merged
ghusse merged 4 commits intoalpha-firebasefrom
create-firebase
Jun 2, 2022
Merged

chore: create firebase package directory#332
ghusse merged 4 commits intoalpha-firebasefrom
create-firebase

Conversation

@ghusse
Copy link
Copy Markdown
Contributor

@ghusse ghusse commented Jun 2, 2022

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

Comment thread .vscode/settings.json Outdated
"typescript.tsdk": "./node_modules/typescript/lib",
"typescript.enablePromptUseWorkspaceTsdk": true
"typescript.enablePromptUseWorkspaceTsdk": true,
"conventionalCommits.scopes": ["firebase"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what will allow us to have different release ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, I did not notice this change. This has been done automatically by my IDE

Copy link
Copy Markdown

@LouisClisson LouisClisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants