Skip to content

chore(firebase): add new empty classes for firebase#333

Closed
ghusse wants to merge 2 commits intoalpha-firebasefrom
chore/add-empty-classes
Closed

chore(firebase): add new empty classes for firebase#333
ghusse wants to merge 2 commits intoalpha-firebasefrom
chore/add-empty-classes

Conversation

@ghusse
Copy link
Copy Markdown
Contributor

@ghusse ghusse commented Jun 2, 2022

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

@ghusse ghusse requested a review from LouisClisson June 2, 2022 14:59
@ghusse ghusse closed this Jun 8, 2022
@romain-gilliotte romain-gilliotte deleted the chore/add-empty-classes branch January 12, 2023 16:34
PMerlet pushed a commit that referenced this pull request Apr 30, 2026
@fastify/express@^4.0.5 depends on fastify-plugin@5 which requires
fastify@5; the agent's framework-mounter tests register on fastify v3
and v4, which fail with FST_ERR_PLUGIN_VERSION_MISMATCH. Reverting the
bump until the agent migrates to fastify@5; #330#333 moved to 'Could
not auto-fix' on the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants