docs(datasources): document how to add multiple data sources#363
Merged
Conversation
Scra3
force-pushed
the
docs/multiple-data-source
branch
from
1f817e3 to
d99231a
Compare
Scra3
force-pushed
the
docs/multiple-data-source
branch
from
d99231a to
248a734
Compare
Member
jeffladiray
reviewed
Jun 30, 2022
Contributor
jeffladiray
left a comment
jeffladiray
left a comment
There was a problem hiding this comment.
That's pure opinion, but to me multiple datasource in a single project is worth a dedicated page, instead of being hidden in the datasource section, as it's a pretty powerful features, and it's far from being natural at first sight.
Maybe this content should be on the same level as Usage/Provided datasources, in the datasources section
Scra3
force-pushed
the
docs/multiple-data-source
branch
4 times, most recently
from
e62c64a to
a6da23c
Compare
Scra3
force-pushed
the
docs/multiple-data-source
branch
from
a6da23c to
705e2ab
Compare
jeffladiray
reviewed
Jun 30, 2022
| @@ -0,0 +1,45 @@ | |||
| You can plug as many data sources as you want, no matter its type. | |||
| For example, you can plug a [Mongoose data source](../provided/mongoose.md) with a [Sql data source](../provided/sql.md). We take care of the compatibility for you. | |||
Contributor
There was a problem hiding this comment.
We take care of the compatibility for you
That not entirely true, as Naming conflict, relationships etc. are handled manually by the developer
Member
Author
There was a problem hiding this comment.
I added this sentence because the user may find it a bit weird to link sql and nosql data sources. I want to reassure the user that it works.
Scra3
force-pushed
the
docs/multiple-data-source
branch
2 times, most recently
from
eb1ee23 to
bff9cc8
Compare
Scra3
force-pushed
the
docs/multiple-data-source
branch
from
bff9cc8 to
7806d8e
Compare
jeffladiray
pushed a commit
that referenced
this pull request
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security
linked to: CU-2fdd916