Skip to content

fix: add polymorphic type filter for has_many :through associations#206

Merged
matthv merged 2 commits intomainfrom
fix/polymorphic-through-relation
Nov 7, 2025
Merged

fix: add polymorphic type filter for has_many :through associations#206
matthv merged 2 commits intomainfrom
fix/polymorphic-through-relation

Conversation

@matthv
Copy link
Member

@matthv matthv commented Nov 6, 2025 •
edited
Loading

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Nov 6, 2025 •
edited
Loading

All good ✅
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

qltysh[bot]
qltysh bot reviewed Nov 6, 2025
View reviewed changes
@qltysh
Copy link

qltysh bot commented Nov 6, 2025 •
edited
Loading

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.02%.

File Coverage Changes
Path File Coverage Δ Indirect
packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb 1.9
packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb 0.8
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@matthv matthv changed the title fix: add origin type field & value attributes to many to many fix: add polymorphic type filter for has_many :through associations Nov 6, 2025
@matthv matthv marked this pull request as draft November 6, 2025 15:00
@matthv matthv force-pushed the fix/polymorphic-through-relation branch from d0ab2a6 to 639b204 Compare November 6, 2025 19:32
@bolinkd bolinkd mentioned this pull request Nov 6, 2025
Closed
@matthv matthv marked this pull request as ready for review November 7, 2025 08:54
@matthv matthv merged commit 2e83084 into main Nov 7, 2025
37 checks passed
@matthv matthv deleted the fix/polymorphic-through-relation branch November 7, 2025 08:59
forest-bot added a commit that referenced this pull request Nov 7, 2025
@forest-bot
chore(release): 1.14.1 [skip ci]
dd5d921 
## [1.14.1](v1.14.0...v1.14.1) (2025-11-07)

### Bug Fixes

* add polymorphic type filter for has_many :through associations ([#206](#206)) ([2e83084](2e83084))
@forest-bot
Copy link
Member

forest-bot commented Nov 7, 2025

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matthv
Copy link
Member Author

matthv commented Nov 7, 2025

fix #205

@apacosta apacosta mentioned this pull request Mar 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

@DayTF DayTF DayTF approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthv @forest-bot @DayTF