fix(rpc agent): allow connect as node rpc#310
Merged
Conversation
matthv
reviewed
May 22, 2026
Member
matthv
left a comment
There was a problem hiding this comment.
Nice catch on the missing path_parameters merge.
I suggest to add a regression test for extract_request_params in base_route_spec.rb.
The specs were updated from eq({}) to eq([]) but none actually test the scenario being fixed (collection_name resolved from path_parameters only)
forest-bot
added a commit
that referenced
this pull request
May 22, 2026
## [1.30.6](v1.30.5...v1.30.6) (2026-05-22) ### Bug Fixes * **rpc agent:** allow connect as node rpc ([#310](#310)) ([6f80070](6f80070))
Member
|
🎉 This PR is included in version 1.30.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security
Note
Fix RPC agent Rails routes to include URL path parameters in request params
extract_request_paramshelper inBaseRoutethat mergespath_parameters,query_parameters, andrequest_parametersso that URL segment params like:collection_nameare available to route handlers.list,create,aggregate, andaction_formpreviously received only query/body params, causingcollection_nameto be missing when provided as a path segment.collection_namefallback return value from{}to[]across all affected handlers.Changes since #310 opened
ForestAdminRpcAgent::Routes::Aggregate#handle_requestto verify that when the aggregation payload omits the:groupskey,Aggregation.newis invoked withgroupsdefaulting to an empty array [e0ffe0d]ForestAdminRpcAgent::Routes::BaseRoute#extract_request_paramsto verify parameter merging behavior from path, query, and body sources with indifferent access and proper filtering of Rails-internal keys [e0ffe0d]Macroscope summarized cc8ced2.