refactor: rewrite the permissions checker as a class#558
Merged
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
VincentMolinie
requested changes
Nov 25, 2020
adriguy
force-pushed
the
feat/roles#07/request-new-permissions-format
branch
from
5c99cfa to
9293914
Compare
VincentMolinie
requested changes
Nov 26, 2020
adriguy
force-pushed
the
feat/roles#07/request-new-permissions-format
branch
from
d0bfddf to
b20ca66
Compare
|
Code Climate has analyzed commit b20ca66 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.5% (49% is the threshold). This pull request will bring the total coverage in the repository to 50.8%. View more on Code Climate. |
VincentMolinie
approved these changes
Nov 26, 2020
Member
VincentMolinie
left a comment
VincentMolinie
left a comment
There was a problem hiding this comment.
Let's merge this ! Good job 👏
Member
|
🎉 This PR is included in version 7.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 8.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist: