Skip to content
This repository was archived by the owner on Apr 21, 2026. It is now read-only.

feat(shared-constants): add MCP_UI_SERVER_NAME, deprecate MCP_UIFORGE_SERVER_NAME #137

Merged
LucasSantana-Dev merged 1 commit into from
Mar 15, 2026
Merged

feat(shared-constants): add MCP_UI_SERVER_NAME, deprecate MCP_UIFORGE_SERVER_NAME #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions patterns/shared-constants/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
});

it('should export all MCP protocol constants', () => {
expect(SharedConstants.MCP_UIFORGE_SERVER_NAME).toBeDefined();

Check warning on line 76 in patterns/shared-constants/__tests__/index.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'MCP_UIFORGE_SERVER_NAME' is deprecated. 


See more on https://sonarcloud.io/project/issues?id=Forge-Space_core&issues=AZzwEUi1mbx9WHcwENyM&open=AZzwEUi1mbx9WHcwENyM&pullRequest=137
expect(SharedConstants.MCP_UI_SERVER_NAME).toBeDefined();
});

it('should export all environment constants', () => {
Expand Down
6 changes: 6 additions & 0 deletions patterns/shared-constants/__tests__/mcp-protocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
JsonRpcVersion,
MCP_SERVER_VERSION,
MCP_GATEWAY_CLIENT_NAME,
MCP_UIFORGE_SERVER_NAME,

Check warning on line 13 in patterns/shared-constants/__tests__/mcp-protocol.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'MCP_UIFORGE_SERVER_NAME' is deprecated. 


See more on https://sonarcloud.io/project/issues?id=Forge-Space_core&issues=AZzwEUkzmbx9WHcwENyN&open=AZzwEUkzmbx9WHcwENyN&pullRequest=137
MCP_UI_SERVER_NAME,
MCP_PROTOCOL_METHODS,
type McpProtocolMethod
} from '../mcp-protocol';
Expand All @@ -29,10 +30,15 @@

it('should have correct client names', () => {
expect(MCP_GATEWAY_CLIENT_NAME).toBe('forge-mcp-gateway-client');
expect(MCP_UIFORGE_SERVER_NAME).toBe('uiforge');

Check warning on line 33 in patterns/shared-constants/__tests__/mcp-protocol.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'MCP_UIFORGE_SERVER_NAME' is deprecated. 


See more on https://sonarcloud.io/project/issues?id=Forge-Space_core&issues=AZzwEUkzmbx9WHcwENyO&open=AZzwEUkzmbx9WHcwENyO&pullRequest=137
expect(typeof MCP_GATEWAY_CLIENT_NAME).toBe('string');
expect(typeof MCP_UIFORGE_SERVER_NAME).toBe('string');

Check warning on line 35 in patterns/shared-constants/__tests__/mcp-protocol.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'MCP_UIFORGE_SERVER_NAME' is deprecated. 


See more on https://sonarcloud.io/project/issues?id=Forge-Space_core&issues=AZzwEUkzmbx9WHcwENyP&open=AZzwEUkzmbx9WHcwENyP&pullRequest=137
});

it('MCP_UI_SERVER_NAME should be the canonical Forge Space server name', () => {
expect(MCP_UI_SERVER_NAME).toBe('forge-ui');
expect(typeof MCP_UI_SERVER_NAME).toBe('string');
});
});

describe('Protocol Methods', () => {
Expand Down Expand Up @@ -177,15 +183,15 @@
);

expect(MCP_GATEWAY_CLIENT_NAME).toContain('gateway');
expect(MCP_UIFORGE_SERVER_NAME).toContain('uiforge');

Check warning on line 186 in patterns/shared-constants/__tests__/mcp-protocol.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'MCP_UIFORGE_SERVER_NAME' is deprecated. 


See more on https://sonarcloud.io/project/issues?id=Forge-Space_core&issues=AZzwEUkzmbx9WHcwENyQ&open=AZzwEUkzmbx9WHcwENyQ&pullRequest=137
expect(MCP_GATEWAY_CLIENT_NAME).toContain('-');
expect(isLowercaseDashUnderscore(MCP_GATEWAY_CLIENT_NAME)).toBe(true);
expect(isLowercaseDash(MCP_UIFORGE_SERVER_NAME)).toBe(true);

Check warning on line 189 in patterns/shared-constants/__tests__/mcp-protocol.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'MCP_UIFORGE_SERVER_NAME' is deprecated. 


See more on https://sonarcloud.io/project/issues?id=Forge-Space_core&issues=AZzwEUkzmbx9WHcwENyR&open=AZzwEUkzmbx9WHcwENyR&pullRequest=137
});

it('should be lowercase with hyphens', () => {
expect(MCP_GATEWAY_CLIENT_NAME).toBe(MCP_GATEWAY_CLIENT_NAME.toLowerCase());
expect(MCP_UIFORGE_SERVER_NAME).toBe(MCP_UIFORGE_SERVER_NAME.toLowerCase());

Check warning on line 194 in patterns/shared-constants/__tests__/mcp-protocol.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'MCP_UIFORGE_SERVER_NAME' is deprecated. 


See more on https://sonarcloud.io/project/issues?id=Forge-Space_core&issues=AZzwEUkzmbx9WHcwENyS&open=AZzwEUkzmbx9WHcwENyS&pullRequest=137

Check warning on line 194 in patterns/shared-constants/__tests__/mcp-protocol.test.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'MCP_UIFORGE_SERVER_NAME' is deprecated. 


See more on https://sonarcloud.io/project/issues?id=Forge-Space_core&issues=AZzwEUkzmbx9WHcwENyT&open=AZzwEUkzmbx9WHcwENyT&pullRequest=137
});
});
});
Expand Down
4 changes: 4 additions & 0 deletions patterns/shared-constants/mcp-protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ export const MCP_SERVER_VERSION = '0.1.0';

export const MCP_GATEWAY_CLIENT_NAME = 'forge-mcp-gateway-client';

/** @deprecated Use MCP_UI_SERVER_NAME instead */
export const MCP_UIFORGE_SERVER_NAME = 'uiforge';

/** Canonical name for the UI generation MCP server (ui-mcp) */
export const MCP_UI_SERVER_NAME = 'forge-ui';

export const MCP_PROTOCOL_METHODS = {
TOOLS_LIST: 'tools/list',
TOOLS_CALL: 'tools/call',
Expand Down
Loading