Feature/shared select component#66
Merged
Merged
Conversation
Clicking the cluster −/+ toggle previously reset the radial view's zoom and pan because (1) toggleClusterCollapse forced didFit=false and (2) the shape-tracking effect treated collapse-induced layout changes identically to filter changes, retriggering fitToView(). Now: drop the explicit didFit reset on collapse, and gate the shape-effect's didFit reset on collapsedSig stability so only filter/data-driven shape changes refit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace the native <select> in PaneFrame with a bits-ui-based Select component that lives in shared/ui and renders a Lucide icon next to each of the 7 graph views (force, tree, radial, matrix, lanes, sankey, sunburst). Trigger and listbox share the same iconography so the active view is recognisable at a glance without reading the label. The component is headless (bits-ui handles ARIA semantics and keyboard navigation), styled exclusively with the existing CSS-variable design tokens (no Tailwind, no inline styles), and exposed via @/shared/ui for future consumers. The drag-handle in PaneFrame is updated to ignore the new trigger and the portal-rendered listbox so picking a view no longer fights the swap-pane gesture. Adds two runtime deps to template/package.json: bits-ui and @lucide/svelte. Build, svelte-check, and live render all green. Refs: PRD-017
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.