fix(score): align scorePoller type with forgeplan score --json wrappe…#71
Merged
Conversation
…r shape
`forgeplan score --all --json` returns `{ errors, results: ScoreEntry[] }`,
but scorePoller was typed as `ScoreEntry[]` and consumers called `.map(...)`
directly on the wrapper, throwing `(... ?? []).map is not a function` at
runtime in InsightsRail and ForceView (via HomePage's `scores` derived).
Introduce ScoreResponse, retype the poller, read `data.results` in the two
call sites. No API contract change — endpoint stays a passthrough.
Refs: rule 22 (read-only proxy preserved)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r shape
forgeplan score --all --jsonreturns{ errors, results: ScoreEntry[] }, but scorePoller was typed asScoreEntry[]and consumers called.map(...)directly on the wrapper, throwing(... ?? []).map is not a functionat runtime in InsightsRail and ForceView (via HomePage'sscoresderived).Introduce ScoreResponse, retype the poller, read
data.resultsin the two call sites. No API contract change — endpoint stays a passthrough.Refs: rule 22 (read-only proxy preserved)