fix: update-signals-sdk

[ryanbas21]

JIRA Ticket

Please link jira ticket here

Description

Type of Change

Please Delete options that are not relevant

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Definition of Done

Check all that apply

• Acceptance criteria is met.
• All tasks listed in the user story have been completed.
• Coded to standards.
• Code peer-reviewed.
• Ensure backward compatibility (special attention).
• API reference docs is updated.
• Unit tests are written.
• Integration tests are written.
• e2e tests are written.
• CI build passing on the feature branch.
• Functional spec is written/updated
• contains example code snippets.
• Change log updated.
• Documentation story is created and tracked.
• UI is completed or ticket is created.
• Demo to PO and team.
• Tech debts and remaining tasks are tracked in separated ticket(s).

Documentation

• Acceptance criteria met
• Spell-check run
• Peer reviewed
• Proofread

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ec30a93

Command	Status	Duration	Result
nx run-many -t build --no-agents	✅ Succeeded	<1s	View ↗
nx affected -t build lint test e2e-ci --agents	✅ Succeeded	<1s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-11-13 23:36:59 UTC

[changeset-bot]

🦋 Changeset detected

Latest commit: ec30a93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@forgerock/javascript-sdk	Patch
@forgerock/ping-protect	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.93%. Comparing base (dd63333) to head (ec30a93).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #466      +/-   ##
===========================================
- Coverage    58.68%   56.93%   -1.76%     
===========================================
  Files          105      105              
  Lines        25680    31600    +5920     
  Branches      1690     1785      +95     
===========================================
+ Hits         15070    17991    +2921     
- Misses       10610    13609    +2999     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ryanbas21]

why this change?

[ryanbas21]

?

[pkg-pr-new]

Open in StackBlitz

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/javascript-sdk@466

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/ping-protect@466

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/token-vault@466

commit: 9ab3822

[adamheath-fr]

When testing these changes the fact that these values are being defaulted to 0 is causing issues as this is setting the port and timeout to 0 (Meaning the agent does not get connected to).

When the values are not set in the node the expectation is that we should be using the default values, which is in line with the signals SDK init call expecting these values to be present ONLY if the default values are not desired - see documentation here https://apidocs.pingidentity.com/pingone/native-sdks/v1/api/#pingone-protect-sdk-for-web:~:text=//%20If%20you%20have,9400)%0A%20%20%20%20%20%20%20%20//%20agentPort%3A%208800

If default values have to be provided in this class, perhaps we should use the Signals SDK default values here instead?

Default values for these configuration options are:

• agentPort = 9400
• agentTimeout = 1000

(Default values inferred from documentation here: https://docs.pingidentity.com/pingone/strong_authentication_mfa/p1_using_the_workforce_trust_agent.html#:~:text=the%20agent%20timeout%20(-,1000%20ms,-)%2C%20use%20the%20PingID )

[cerebrl]

Okay, I can make the changes. Rather than dealing with default values, I'll just remove the config property if it's not on the callback. Would that work better?

[adamheath-fr]

That would be great - keeps things in line with the Signals expected SDK behaviour and if they update their defaults we don't need any additional update.

Thanks

[adamheath-fr]

Tested these changes with the new beta and things are looking good - thanks for the swift turnaround on this. ✅