Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thin-numbers-hammer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@forgerock/javascript-sdk': minor
---

Add feature to provide JSON outcome response to callback if requested
116 changes: 116 additions & 0 deletions packages/javascript-sdk/src/fr-webauthn/fr-webauthn.mock.data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -373,3 +373,119 @@ export const webAuthnAuthMetaCallback70StoredUsername = {
},
],
};

export const webAuthnAuthMetaCallbackJsonResponse = {
authId:
'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJhdXRoSW5kZXhWYWx1ZSI6IndlYmF1dGhuIiwib3RrIjoicXN1dTA0anNxZ2hmcGpubjFiM2IxdDh0NTQiLCJhdXRoSW5kZXhUeXBlIjoic2VydmljZSIsInJlYWxtIjoiLyIsInNlc3Npb25JZCI6IipBQUpUU1FBQ01ERUFCSFI1Y0dVQUNFcFhWRjlCVlZSSUFBSlRNUUFBKmV5SjBlWEFpT2lKS1YxUWlMQ0pqZEhraU9pSktWMVFpTENKaGJHY2lPaUpJVXpJMU5pSjkuWlhsS01HVllRV2xQYVVwTFZqRlJhVXhEU214aWJVMXBUMmxLUWsxVVNUUlJNRXBFVEZWb1ZFMXFWVEpKYVhkcFdWZDRia2xxYjJsYVIyeDVTVzR3TGk0M01qbDZSRXhsU0hwM1pXbFVPRll6VDB4cFgycEJMbGxpV1Y5WVl6WTJPVWxJU0MxT01VTk5Va05MZVROdFZFaHliVlJSVDJoV2VVSTBUVUUzYUVoRmFISjFTRU5SVWpWeWVsQnRZVzFpYlRNeFFqQlhSMlZxVEU5allUWllWMEUwTVROSlozRnVXV2gwV0hadlRHaE9VMkpDYUdkUlJFaGFSV1pLVmxaeWNsOTBTRUpJU1Y5elIyMVhNMEZYWm5wTk9WZElXblJMTm10ZmFITm9hemRNUTBkSVkwbzVhVGQ2Wnpob2FUbFROVm8wTVVkbk1rZFpXSFJJTnpoWlRGOVVaVTl5VWtOc1ozTlBkbDlWTWpGRFJ6STBReTFMWVRJNVMxRm9ibFYwTTNCVlozWldiamRCVUhWdWRFdEdaR2h6VERselJ6QlBTVnAwYzNoV1NqTXRPVmc1TmpSM2VrVldSV2w2Vnprek9XNTRlVm94VjNWVVgzWmpTRzFFV2t4eE0yWTJXamswVlVWTU5VNDJjMjVMTWs5U01XeDBOR3BrVld3eWVVMVRaVXR6YzJkb2VIRmlNMnhoZW1WQlVtMDBWM3BUVld4c1JFUTRVVVJuWDNoSFozSktlVmhQZWxCa1RWUnZYeTB0U1c0MFkxVjBTeloxTVdWSVkxOWhZbkZLTlhsRVpWcEpaM04yYkU5eE5qVTJkVU5KV0dzNU9GbElWMHBEWkhSR1MzcGtWV1k1ZG0xNlJIWk9iMmxXTlZnd2RXd3hiRzlTV0dOaFZtTkhVMDlaTlVGNFdITkJkSGd5UVhkVlVXUnViR0pmYTJodWN5MUhXblowZUVOM1lYRldlR2h1T1RsdVVWY3ljWFphUjNCTk1raFVPRzFMYUU5SVIyOVJOQzFWVkZrNVVWbDBNbGcwZGpaZlQzSk5kemxUZEdwSVl6RnRjMTkxVTI1VWVtVmpUR2RYUkVZdFVFNXNVM0J1Ymkxc1EyRlljRXREVmxsS1FVeDVUbWhoWDBJeGQwNTRSRzV0WW5vNVdYVjFXakZMYzFWTkxVZHJjVlJZYkY5c2JqUlBMVEpXVUhoTVFYSjFVblZOZW0xaVgxQndRMjlqY1d4T1Z6Sm1jWHBPV25seVlteE9RVEZXUkdaM04yYzJNMnhmTkhvd05UWkhlRXhOVjBOck5rOTZVQzFMY1RJMVlXTmxSa0ZQWWpGd1JtMXBkVGgzWW5kUGVITmtZa0ZLVW0xSWMxVlJWVzlQWm5aQlpURldORmcyUW5veGNFeG9SV3d0UzNGblkwMDBjMjluYTFab1YyRkhZWFpyVFUxSVFTNVlWRVpOV1d4R2F6bHFSV1V5VG5CamFIZDVZVzVuLmYyS2t1RlhnM05MUU1NbGNnMU1HU2Y2YTZQVmdJalhtUC1wcmJhQTNtTnciLCJleHAiOjE2MTM0OTc0OTksImlhdCI6MTYxMzQ5NzE5OX0.EuDmsY3C6I6vc_x7KlkW4rSQJY1FWevbGGmxkSu4HVU',
callbacks: [
{
type: 'MetadataCallback',
output: [
{
name: 'data',
value: {
_action: 'webauthn_authentication',
challenge: 'qnMsxgya8h6mUc6OyRu8jJ6Oq16tHV3cgE7juXGMDbg=',
allowCredentials: '',
_allowCredentials: [],
timeout: '60000',
userVerification: 'preferred',
relyingPartyId: 'rpId: "humorous-cuddly-carrot.glitch.me",',
_relyingPartyId: 'humorous-cuddly-carrot.glitch.me',
_type: 'WebAuthn',
supportsJsonResponse: true,
},
},
],
},
{
type: 'HiddenValueCallback',
output: [
{
name: 'value',
value: 'false',
},
{
name: 'id',
value: 'webAuthnOutcome',
},
],
input: [
{
name: 'IDToken2',
value: 'webAuthnOutcome',
},
],
},
],
};

export const webAuthnRegMetaCallbackJsonResponse = {
authId:
'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ3aGl0ZWxpc3Qtc3RhdGUiOiJjMjMzNDRkMC04ZTlhLTRhM2QtODZkMS1mNTIwNTExZmM3NjciLCJhdXRoSW5kZXhWYWx1ZSI6IkFuZHlXZWJBdXRobiIsIm90ayI6ImFzdTNjMmo4YThta2w0aWQyN3FndGFuaTVqIiwiYXV0aEluZGV4VHlwZSI6InNlcnZpY2UiLCJyZWFsbSI6Ii9hbHBoYSIsInNlc3Npb25JZCI6IipBQUpUU1FBQ01ESUFCSFI1Y0dVQUNFcFhWRjlCVlZSSUFBSlRNUUFDTURFLipleUowZVhBaU9pSktWMVFpTENKamRIa2lPaUpLVjFRaUxDSmhiR2NpT2lKSVV6STFOaUo5LlpYbEtNR1ZZUVdsUGFVcExWakZSYVV4RFNteGliVTFwVDJsS1FrMVVTVFJSTUVwRVRGVm9WRTFxVlRKSmFYZHBXVmQ0YmtscWIybGFSMng1U1c0d0xpNVJkVXBMWTBnNGIwUjViemxZV0ZKcE0wNDJjQzFCTG0xRU0xOWFOVlZrZURGeVYxUk9lR2MwVUVWNFNHMW1OMGN5TkdoSU1YRXpPV0ZhVDNoaWREbFlUa000VEZscU1VRm1la1pXUzBkME1ubEJVMmxvT1hCNmJIRjNOVTQ0Y0ZsblZXRnplV2g1VEdWUFdtWldaVkpqVldNMmNGRjJOVmxhZEROdGNHWnZOMWRuV1hsWVNrRnZRWGQxZEhka2NYVlhaVXBYWkRScVl6TlBkRTFOTlVOV1NWaGtTRFZqVURGTVlrRjVTblJHWVd4NlIyWkplVGRtWW0xQll6SkZTbGxLUVdGNFZqTTRSa0l0TjFWVFFWZEVaMWxsUW14elYzQXRjWEZSYlRSdFIyUnBkRlpwYzBFdGNWRTFUbEpaU0cxQlJXSnpVVXBtWVdoRVQzSllUMFo1ZVZNM2VUUnVaV3BHUjNaWExVaFFRV054YjJ0TGNFMWZhVFkyWVRrdFZrbE9UMWxaY0RoWFQxaFFiR2hVTWt4YVIwVk1SVEpuVUhsWFkzcDJNV2xCVjBwcU4zVlVjVWx2UjFCTllVNUxSSEJKZGpaTk4wdFphVnA2YzJoUE9IRmxTMWw1VjJ3emNWWk9Tek4wWjJOamNGbERZVkJmT0ZGcGNuZG9iMkV3UjNOSWRIRk9SR04yYlhCUldIbE1ZM1Z3VGpkdmJGbDNhREV5WlVsTU9HaEZla0pLUldkMlVFaGpTM0JDYmxKVVYwOWlkemhJUlZobFJFZzRNbGxDWmxJdGVXMXpYMjlZT0c1dFpURldhbFJvUVZnMlRHZGtkbkUwVTJ4MmJYVjFYMTlzZVZack9GQnVZV3RDTldvMWVHOUtkVkUwTjFwRlZERnBUbGsxVkhCQlVHNUNOMjVuVVhaeWExRnlWR1ZHZFZKdU1EUlFPV1E0TTJ0MFVXcEhaMlpyUVdkbVNrNWpiek54YUZOR1dGb3dWM2swWldkUlpHdGhUVFU0ZGxSVVJtRlhlRjl1VERkdk9XdGFha3hXUjA4eFh6Sk9Oa0ZGVW5SVWFpMU9MVll6UmxwMlJYTnpRbnBTV1V0V2VGUm5UMTlRUTNWVmMxaDJjVzFVU1ZkcFNUQnhYekE0ZFhSVlVXcGpRMHhWUjNCVlZHRnVhR0pCVldKV1R6SnZVWHBVVTJ4bkxUTTJhakJWZVMxdlYxQTVNblo0ZVhvMWRUSkZkRVpwWkRaRGMxWmFMVVl3TFdkbWNFTnBkUzFGVlVzNFJITklhelZCUXpFNVp6VnRNMkY0Tmw5TFZuTlBkMmxIWDIxMU5tcHhOVzlsTlhkbFFtVm9iRE5RV0ZCTmFERTRTRWRrTTFOVVRHUmphVjl0VXpKTFJuYzJTM2xvWVd0a1dIcElXREZSTFdwRVIzWkRlRzF4YzJGcFZuUllhVlJSTXpSM1pVdGFhRk15VEVSVVpITklWM0JZTFdReFREa3lSMlJrVFc1UGJWRkhlV3A0WkRScU16TlFPVW96TVdGNGMyVXhZbDlFY1MxeWFXZHZZM2huTG1wR2VXWmxRVTlRVjBwMldUaHNaV3B1Wm1RemIyYy43YmdYcE5RNGRLSEpTeGpmUEVZZm44MGxZc3owaXBwNngyaURtRXlqd1JjIiwiZXhwIjoxNzQyODQzMDQ4LCJpYXQiOjE3NDI4NDI3NDh9.3zuPwPZVeFSwezhmzSZe-HW-22zo1HXwEPJO5jGl0Cg',
callbacks: [
{
type: 'MetadataCallback',
output: [
{
name: 'data',
value: {
_action: 'webauthn_registration',
challenge: 'QMmVc2lSU6G+jx6IYNOd6EaPz6X8jBzkxI9TMdVyWTw=',
attestationPreference: 'none',
userName: 'demo',
userId: 'NzcyNTI2NmMtYmZiZi00ZGFiLWFhYzEtNjY3NjUyMGIzNmZl',
relyingPartyName: 'ForgeRock',
authenticatorSelection:
'{"userVerification":"preferred","residentKey":"required","requireResidentKey":true}',
_authenticatorSelection: {
userVerification: 'preferred',
residentKey: 'required',
requireResidentKey: true,
},
pubKeyCredParams:
'[ { "type": "public-key", "alg": -257 }, { "type": "public-key", "alg": -7 } ]',
_pubKeyCredParams: [
{
type: 'public-key',
alg: -257,
},
{
type: 'public-key',
alg: -7,
},
],
timeout: '60000',
excludeCredentials: '',
_excludeCredentials: [],
displayName: 'demo',
relyingPartyId: 'id: "idc.petrov.ca",',
_relyingPartyId: 'idc.petrov.ca',
extensions: {},
_type: 'WebAuthn',
supportsJsonResponse: true,
},
},
],
},
{
type: 'HiddenValueCallback',
output: [
{
name: 'value',
value: 'false',
},
{
name: 'id',
value: 'webAuthnOutcome',
},
],
input: [
{
name: 'IDToken2',
value: 'webAuthnOutcome',
},
],
},
],
};
50 changes: 43 additions & 7 deletions packages/javascript-sdk/src/fr-webauthn/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,20 +104,28 @@ abstract class FRWebAuthn {
const { hiddenCallback, metadataCallback, textOutputCallback } = this.getCallbacks(step);
if (hiddenCallback && (metadataCallback || textOutputCallback)) {
let outcome: ReturnType<typeof this.getAuthenticationOutcome>;
let credential: PublicKeyCredential | null = null;

try {
let publicKey: PublicKeyCredentialRequestOptions;
if (metadataCallback) {
const meta = metadataCallback.getOutputValue('data') as WebAuthnAuthenticationMetadata;
publicKey = this.createAuthenticationPublicKey(meta);

credential = await this.getAuthenticationCredential(
publicKey as PublicKeyCredentialRequestOptions,
);
outcome = this.getAuthenticationOutcome(credential);
} else if (textOutputCallback) {
publicKey = parseWebAuthnAuthenticateText(textOutputCallback.getMessage());

credential = await this.getAuthenticationCredential(
publicKey as PublicKeyCredentialRequestOptions,
);
outcome = this.getAuthenticationOutcome(credential);
} else {
throw new Error('No Credential found from Public Key');
}
// TypeScript doesn't like `publicKey` being assigned in conditionals above
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
const credential = await this.getAuthenticationCredential(publicKey);
outcome = this.getAuthenticationOutcome(credential);
} catch (error) {
if (!(error instanceof Error)) throw error;
// NotSupportedError is a special case
Expand All @@ -129,6 +137,18 @@ abstract class FRWebAuthn {
throw error;
}

if (metadataCallback) {
const meta = metadataCallback.getOutputValue('data') as WebAuthnAuthenticationMetadata;
if (meta?.supportsJsonResponse && credential && 'authenticatorAttachment' in credential) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor I would suggest keys like authenticatorAttachment and data to be used from Constants files as they are re-used across files.

hiddenCallback.setInputValue(
JSON.stringify({
authenticatorAttachment: credential.authenticatorAttachment,
legacyData: outcome,
}),
);
return step;
}
}
hiddenCallback.setInputValue(outcome);
return step;
} else {
Expand All @@ -154,19 +174,20 @@ abstract class FRWebAuthn {
const { hiddenCallback, metadataCallback, textOutputCallback } = this.getCallbacks(step);
if (hiddenCallback && (metadataCallback || textOutputCallback)) {
let outcome: OutcomeWithName<string, AttestationType, PublicKeyCredential>;
let credential: PublicKeyCredential | null = null;

try {
let publicKey: PublicKeyCredentialRequestOptions;
if (metadataCallback) {
const meta = metadataCallback.getOutputValue('data') as WebAuthnRegistrationMetadata;
publicKey = this.createRegistrationPublicKey(meta);
const credential = await this.getRegistrationCredential(
credential = await this.getRegistrationCredential(
publicKey as PublicKeyCredentialCreationOptions,
);
outcome = this.getRegistrationOutcome(credential);
} else if (textOutputCallback) {
publicKey = parseWebAuthnRegisterText(textOutputCallback.getMessage());
const credential = await this.getRegistrationCredential(
credential = await this.getRegistrationCredential(
publicKey as PublicKeyCredentialCreationOptions,
);
outcome = this.getRegistrationOutcome(credential);
Expand All @@ -183,6 +204,21 @@ abstract class FRWebAuthn {
hiddenCallback.setInputValue(`${WebAuthnOutcome.Error}::${error.name}:${error.message}`);
throw error;
}

if (metadataCallback) {
const meta = metadataCallback.getOutputValue('data') as WebAuthnAuthenticationMetadata;
if (meta?.supportsJsonResponse && credential && 'authenticatorAttachment' in credential) {
hiddenCallback.setInputValue(
JSON.stringify({
authenticatorAttachment: credential.authenticatorAttachment,
legacyData:
deviceName && deviceName.length > 0 ? `${outcome}::${deviceName}` : outcome,
}),
);
return step;
}
}

hiddenCallback.setInputValue(
deviceName && deviceName.length > 0 ? `${outcome}::${deviceName}` : outcome,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you will be missing the deviceName from the outcome in the case that the if (metadataCallback) { is true and you send the new format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. Will update now.

);
Expand Down
2 changes: 2 additions & 0 deletions packages/javascript-sdk/src/fr-webauthn/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ interface WebAuthnRegistrationMetadata {
userId: string;
userName: string;
displayName?: string;
supportsJsonResponse?: boolean;
}

interface WebAuthnAuthenticationMetadata {
Expand All @@ -82,6 +83,7 @@ interface WebAuthnAuthenticationMetadata {
relyingPartyId: string;
timeout: number;
userVerification: UserVerificationType;
supportsJsonResponse?: boolean;
}

interface WebAuthnCallbacks {
Expand Down
Loading