fix: session-logout-logic #544
Conversation
🦋 Changeset detectedLatest commit: 58360de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 58360de.
☁️ Nx Cloud last updated this comment at |
.changeset/cool-ligers-dress.md
Outdated
| '@forgerock/javascript-sdk': patch | ||
| --- | ||
|
|
||
| fix logic for when we should call session revoke |
There was a problem hiding this comment.
I'd reword this for improved clarity:
Fix condition for determining
sessionendpoint request for terminating session in AIC/AM
| const { serverConfig } = Config.get(configOptions); | ||
|
|
||
| if (getEndpointPath('sessions', realmPath, serverConfig.paths)) { | ||
| if (!serverConfig.paths || (serverConfig.paths && 'sessions' in serverConfig.paths)) { |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #544 +/- ##
===========================================
- Coverage 58.68% 58.68% -0.01%
===========================================
Files 105 105
Lines 25681 25680 -1
Branches 1690 1690
===========================================
- Hits 15071 15070 -1
Misses 10610 10610 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JIRA Ticket
None
Description
Noticed some issues with logout flow, this logic fix was required to make it work as intended.