Skip to content

fix: ping-protect-versioning #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

fix: ping-protect-versioning #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@
}
],
"commit": false,
"fixed": [["@forgerock/javascript-sdk"]],
"fixed": [["@forgerock/javascript-sdk"], ["@forgerock/ping-protect"]],
Copy link
Contributor

@ancheetah ancheetah Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause protect to always be versioned along with the js sdk, changing the protect version from 4.6.0 --> 4.8.1 in this release. Is that correct/intended?

Copy link
Contributor Author

@ryanbas21 ryanbas21 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't version it with the SDK, but the SDK would get bumped because it's a dependent.

Copy link
Contributor Author

@ryanbas21 ryanbas21 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They would have to be grouped in the same sub-array to be fixed together (pretty sure but we can see in the release pr)

"linked": [],
"access": "public",
"baseBranch": "master",
"updateInternalDependencies": "patch",
"ignore": [
"@forgerock/ping-protect",
"@forgerock/token-vault",
"autoscript-apps",
"autoscript-suites",
Expand Down
5 changes: 5 additions & 0 deletions .changeset/stupid-eagles-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@forgerock/ping-protect': patch
---

fix the protect-package versioning. no functional changes to protect package, but allow more loose versioning on javascript-sdk
5 changes: 5 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ jobs:
./dist/**
retention-days: 30

# make sure we have a build.
- run: pnpm exec nx run-many -t build
env:
NX_CLOUD_DISTRIBUTED_EXECUTION: false

- run: git status
- name: publish
uses: changesets/action@v1
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"build": "nx affected --target=build",
"clean": "shx rm -rf ./{coverage,dist,docs,node_modules,tmp}/ ./{packages,e2e}/*/{dist,node_modules}/ && git clean -fX -e \"!.env*,nx-cloud.env\"",
"ci:release": "pnpm publish -r --no-git-checks && changeset tag",
"ci:version": "changeset version && pnpm install --no-frozen-lockfile && pnpm nx format:write",
"ci:version": "changeset version && pnpm install --no-frozen-lockfile && pnpm nx format:write --uncommitted",
"changeset": "changeset",
"commit": "git cz",
"docs": "nx affected --target=typedoc",
Expand Down
2 changes: 1 addition & 1 deletion packages/javascript-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@forgerock/javascript-sdk",
"version": "4.8.1",
"version": "4.8.2",
Copy link
Contributor

@ancheetah ancheetah Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 4.8.3 or will the changeset auto bump this? The current release in Github is already 4.8.2

Copy link
Contributor Author

@ryanbas21 ryanbas21 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would get bumped, i just manually made this up to date because i had to do a manual publish for the last release

"description": "ForgeRock JavaScript SDK",
"author": "ForgeRock",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/ping-protect/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
},
"types": "./dist/index.ts.d.ts",
"dependencies": {
"@forgerock/javascript-sdk": "workspace:*"
"@forgerock/javascript-sdk": "workspace:^"
Copy link
Contributor

@ancheetah ancheetah Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a version number after this? What does the caret mean when it's alone like this?

Copy link
Contributor Author

@ryanbas21 ryanbas21 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm workspace syntax allows for ^, ~, or *

  • means - fixed version
    ~ means patch only
    ^ means minors allowed

so if the forgerock/javascript-sdk is at version 4.8.2 when we publish this it translates to

4.8.2
^4.8.2
~4.8.2

respectively. so in this case changing the * to a ^ gives us ^4.8.2 instead of 4.8.2

pnpm automatically resolves this syntax when publish is called

}
}
2 changes: 1 addition & 1 deletion pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading