fix: ping-protect-versioning #546
Conversation
🦋 Changeset detectedLatest commit: ba1aa07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryanbas21
force-pushed
the
fix-protect-package-versioning
branch
from
f6b6c10 to
6bcd150
Compare
|
View your CI Pipeline Execution ↗ for commit a87b517.
☁️ Nx Cloud last updated this comment at |
ryanbas21
force-pushed
the
fix-protect-package-versioning
branch
2 times, most recently
from
e2cb0e6 to
ba1aa07
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #546 +/- ##
========================================
Coverage 58.68% 58.68%
========================================
Files 105 105
Lines 25680 25680
Branches 1690 1690
========================================
Hits 15070 15070
Misses 10610 10610 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryanbas21
force-pushed
the
fix-protect-package-versioning
branch
from
ba1aa07 to
a87b517
Compare
| { | ||
| "name": "@forgerock/javascript-sdk", | ||
| "version": "4.8.1", | ||
| "version": "4.8.2", |
There was a problem hiding this comment.
Should this be 4.8.3 or will the changeset auto bump this? The current release in Github is already 4.8.2
There was a problem hiding this comment.
it would get bumped, i just manually made this up to date because i had to do a manual publish for the last release
| ], | ||
| "commit": false, | ||
| "fixed": [["@forgerock/javascript-sdk"]], | ||
| "fixed": [["@forgerock/javascript-sdk"], ["@forgerock/ping-protect"]], |
There was a problem hiding this comment.
This will cause protect to always be versioned along with the js sdk, changing the protect version from 4.6.0 --> 4.8.1 in this release. Is that correct/intended?
There was a problem hiding this comment.
It won't version it with the SDK, but the SDK would get bumped because it's a dependent.
There was a problem hiding this comment.
They would have to be grouped in the same sub-array to be fixed together (pretty sure but we can see in the release pr)
| "types": "./dist/index.ts.d.ts", | ||
| "dependencies": { | ||
| "@forgerock/javascript-sdk": "workspace:*" | ||
| "@forgerock/javascript-sdk": "workspace:^" |
There was a problem hiding this comment.
Should there be a version number after this? What does the caret mean when it's alone like this?
There was a problem hiding this comment.
pnpm workspace syntax allows for ^, ~, or *
- means - fixed version
~ means patch only
^ means minors allowed
so if the forgerock/javascript-sdk is at version 4.8.2 when we publish this it translates to
4.8.2
^4.8.2
~4.8.2
respectively. so in this case changing the * to a ^ gives us ^4.8.2 instead of 4.8.2
pnpm automatically resolves this syntax when publish is called
JIRA Ticket
N/A
Description
This is a publish to fix the versioning problem presented when using
ping-protect. We are now using the ~^so that any minor will be picked up.https://pnpm.io/workspaces#publishing-workspace-packages
shows a reference to how this is translated