SDKS 3829/error node#161
Conversation
🦋 Changeset detectedLatest commit: 451eec7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
81a9412 to
3275a64
Compare
|
View your CI Pipeline Execution ↗ for commit 451eec7.
☁️ Nx Cloud last updated this comment at |
| "eslint-plugin-prettier": "^5.1.3", | ||
| "fast-check": "^3.19.0", | ||
| "husky": "^9.0.0", | ||
| "jiti": "2.4.2", |
There was a problem hiding this comment.
nx added this, seems to be used in eslint and other things.
3275a64 to
f1a9ff5
Compare
| }, | ||
| httpStatus: 400, | ||
| server: { | ||
| id: 'cqm26fxq1v', |
There was a problem hiding this comment.
I think this test, should probably be better written, so I will update this after initial feedback.
This test probably needs to test given a state of a continue node, that the error node updates properly.
|
Deployed 7822b48 to https://ForgeRock.github.io/ping-javascript-sdk/pr-161/7822b48c3b2b468dea183adf25dea73368be9647 branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (14.28%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 44.22% 44.03% -0.20%
==========================================
Files 30 30
Lines 1438 1458 +20
Branches 175 175
==========================================
+ Hits 636 642 +6
- Misses 802 816 +14
🚀 New features to boost your workflow:
|
f1a9ff5 to
4b966c6
Compare
error-node has be be intelligently merged with continue node properties, so that it is in a submittable state.
fixed test case, and re-added error to collectors method
1d0612d to
451eec7
Compare
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-3829
Description
Error node needs to be submittable, so we need to persist the properties of a continue node so that a developer can submit error nodes.