Skip to content

SDKS 3829/error node#161

Merged
ryanbas21 merged 3 commits into
mainfrom
SDKS-3829/error-node
Mar 17, 2025
Merged

SDKS 3829/error node#161
ryanbas21 merged 3 commits into
mainfrom
SDKS-3829/error-node

Conversation

@ryanbas21
Copy link
Copy Markdown
Collaborator

  • chore: update-nx
  • fix: error-node-continue-node

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-3829

Description

Error node needs to be submittable, so we need to persist the properties of a continue node so that a developer can submit error nodes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: 451eec7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@forgerock/davinci-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryanbas21 ryanbas21 force-pushed the SDKS-3829/error-node branch from 81a9412 to 3275a64 Compare March 11, 2025 20:25
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Mar 11, 2025

View your CI Pipeline Execution ↗ for commit 451eec7.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 22s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-17 18:28:32 UTC

Comment thread package.json
"eslint-plugin-prettier": "^5.1.3",
"fast-check": "^3.19.0",
"husky": "^9.0.0",
"jiti": "2.4.2",
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nx added this, seems to be used in eslint and other things.

@ryanbas21 ryanbas21 force-pushed the SDKS-3829/error-node branch from 3275a64 to f1a9ff5 Compare March 11, 2025 21:15
},
httpStatus: 400,
server: {
id: 'cqm26fxq1v',
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test, should probably be better written, so I will update this after initial feedback.

This test probably needs to test given a state of a continue node, that the error node updates properly.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2025

Deployed 7822b48 to https://ForgeRock.github.io/ping-javascript-sdk/pr-161/7822b48c3b2b468dea183adf25dea73368be9647 branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 44.03%. Comparing base (5ebb444) to head (451eec7).

Files with missing lines Patch % Lines
packages/davinci-client/src/lib/node.slice.ts 14.28% 12 Missing ⚠️

❌ Your patch status has failed because the patch coverage (14.28%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   44.22%   44.03%   -0.20%     
==========================================
  Files          30       30              
  Lines        1438     1458      +20     
  Branches      175      175              
==========================================
+ Hits          636      642       +6     
- Misses        802      816      +14     
Files with missing lines Coverage Δ
packages/davinci-client/src/lib/node.types.ts 100.00% <ø> (ø)
packages/davinci-client/src/lib/node.slice.ts 79.38% <14.28%> (+0.10%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanbas21 ryanbas21 force-pushed the SDKS-3829/error-node branch from f1a9ff5 to 4b966c6 Compare March 13, 2025 20:06
Comment thread packages/davinci-client/src/lib/node.slice.ts
Comment thread e2e/davinci-suites/src/basic.test.ts Outdated
Comment thread e2e/davinci-suites/src/basic.test.ts
error-node has be be intelligently merged with continue node properties,
so that it is in a submittable state.
fixed test case, and re-added error to collectors method
@ryanbas21 ryanbas21 force-pushed the SDKS-3829/error-node branch from 1d0612d to 451eec7 Compare March 17, 2025 18:17
@ryanbas21 ryanbas21 merged commit ed7df03 into main Mar 17, 2025
@ryanbas21 ryanbas21 deleted the SDKS-3829/error-node branch March 17, 2025 18:33
@ryanbas21 ryanbas21 mentioned this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants