Skip to content

Fix resume return#204

Merged
ryanbas21 merged 2 commits into
mainfrom
fix-resume-return
Apr 3, 2025
Merged

Fix resume return#204
ryanbas21 merged 2 commits into
mainfrom
fix-resume-return

Conversation

@ryanbas21
Copy link
Copy Markdown
Collaborator

@ryanbas21 ryanbas21 commented Apr 2, 2025

JIRA Ticket

No Jira

Description

The resume method was returning the raw response from davinci, we should return the shaped node from the state.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: 4f92b53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@forgerock/davinci-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 2, 2025

View your CI Pipeline Execution ↗ for commit f473565.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 21s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-03 19:04:29 UTC

@ryanbas21 ryanbas21 force-pushed the fix-resume-return branch from 4f92b53 to f473565 Compare April 3, 2025 19:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

Deployed 05c4788 to https://ForgeRock.github.io/ping-javascript-sdk/pr-204/05c4788e5d8d9c5a7d57fa7372df4404d53e4314 branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.59%. Comparing base (e3235da) to head (f473565).

Files with missing lines Patch % Lines
packages/davinci-client/src/lib/client.store.ts 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   50.59%   50.59%           
=======================================
  Files          24       24           
  Lines        1354     1354           
  Branches      177      177           
=======================================
  Hits          685      685           
  Misses        669      669           
Files with missing lines Coverage Δ
packages/davinci-client/src/lib/client.store.ts 0.45% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanbas21 ryanbas21 merged commit ad21550 into main Apr 3, 2025
3 checks passed
@ryanbas21 ryanbas21 mentioned this pull request Apr 3, 2025
@SteinGabriel SteinGabriel deleted the fix-resume-return branch April 17, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants