fix: handle-form-data-with-more-safety#226
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5bd7e8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryanbas21
changed the title
Contributor
|
View your CI Pipeline Execution ↗ for commit 5bd7e8a.
☁️ Nx Cloud last updated this comment at |
cerebrl
approved these changes
Apr 11, 2025
It's not possible to receive responses from server that have no `formData` key. We should be defensive about how we handle this lookup.
ryanbas21
force-pushed
the
fix-form-data
branch
from
bb8d3c8 to
5bd7e8a
Compare
cerebrl
approved these changes
Apr 11, 2025
Contributor
|
Deployed 917b420 to https://ForgeRock.github.io/ping-javascript-sdk/pr-226/917b4207ad487e8f2a8c588b853eaa52ebe27519 branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 45.18% 50.84% +5.65%
==========================================
Files 33 24 -9
Lines 1547 1363 -184
Branches 186 178 -8
==========================================
- Hits 699 693 -6
+ Misses 848 670 -178
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
n/a
Description
It's not possible to receive responses from server that have no
formDatakey. We should be defensive about how we handle this lookup.