chore: update-routes #365

ryanbas21 · 2025-08-07T20:50:45Z

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-4260
https://pingidentity.atlassian.net/browse/SDKS-4263

Description

Update routes, clean up issues. Needs further testing and addition of responses.

nx-cloud · 2025-08-07T20:51:26Z

View your CI Pipeline Execution ↗ for commit 73f522d

Command	Status	Duration	Result
`nx run-many -t build`	✅ Succeeded	<1s	View ↗
`nx affected -t build typecheck lint test e2e-ci`	✅ Succeeded	2m 5s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2025-08-14 21:18:08 UTC

codecov-commenter · 2025-08-07T20:53:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.47%. Comparing base (777e771) to head (73f522d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   57.58%   55.47%   -2.11%     
==========================================
  Files          32       32              
  Lines        2044     2044              
  Branches      321      341      +20     
==========================================
- Hits         1177     1134      -43     
- Misses        867      910      +43

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-08-07T20:53:45Z

Deployed 9cd81fe to https://ForgeRock.github.io/ping-javascript-sdk/pr-365/9cd81feda4202aa1717199bc80b1406815490966 branch gh-pages in ForgeRock/ping-javascript-sdk

github-actions · 2025-08-07T20:53:50Z

📦 Bundle Size Analysis

🚨 Significant Changes

🔺 @forgerock/oidc-client - 21.1 KB (+3.1 KB, +17.4%)

📊 Minor Changes

📈 @forgerock/sdk-types - 5.9 KB (+0.0 KB)
📈 @forgerock/sdk-request-middleware - 4.4 KB (+0.2 KB)

➖ No Changes

➖ @forgerock/protect - 152.3 KB
➖ @forgerock/davinci-client - 34.1 KB
➖ @forgerock/sdk-utilities - 4.0 KB
➖ @forgerock/device-client - 9.2 KB
➖ @forgerock/iframe-manager - 2.4 KB
➖ @forgerock/storage - 1.4 KB
➖ @forgerock/sdk-logger - 1.6 KB
➖ @forgerock/sdk-oidc - 3.5 KB

11 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated

Current Size: Total gzipped size of all files in the package's dist directory
Baseline: Comparison against the latest build from the main branch
Files included: All build outputs except source maps and TypeScript build cache
Exclusions: .map, .tsbuildinfo, and .d.ts.map files

_{🔄 Updated automatically on each push to this PR}

changeset-bot · 2025-08-08T17:26:37Z

⚠️ No Changeset found

Latest commit: 73f522d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cerebrl

Just left a few comments.

cerebrl · 2025-08-12T17:27:31Z

e2e/mock-api-v2/src/handlers/authorize.handler.ts

+      const acr_value = urlParams?.acr_values ?? '';

-      const response = yield* handleAuthorize(urlParams);
+      if (!acr_value) {


Why are we requiring the use of acr_values?

because i have no way of directing the code to a given flow, unless I provide a default.

We could have a fallback, but I see what you're saying. We can address this later.

cerebrl · 2025-08-12T17:54:40Z

e2e/mock-api-v2/src/handlers/capabilities.handler.ts

+      const acr_value = urlParams?.acr_values ?? '';
+      console.log('acr_value', acr_value);
+
+      if (!acr_value) {
+        return yield* Effect.fail(new HttpApiError.NotFound());
+      }


Are ACR Values used within this route? I thought ACR was an /authorize.

I need to know what flow to pull from, unless we keep the state in another cookie, i have no way of mapping the current request to the responseMap.

I think a cookie is a good idea, but let's not worry about it right now.

cerebrl · 2025-08-12T19:06:07Z

e2e/mock-api-v2/src/handlers/capabilities.handler.ts

+       */
+      if (!stepIndexCookie) {
+        console.log('no step index');
+        return yield* Effect.fail(new HttpApiError.NotFound());


Should this error be more detailed, rather than just 404?

cerebrl · 2025-08-12T19:14:54Z

e2e/mock-api-v2/src/schemas/capabilities/capabilities.response.schema.ts

+const ProtectSDKRequestFormData = Schema.Struct({
+  value: Schema.Struct({
+    protectsdk: Schema.String,
+  }),
+});


We can remove this now as this has been removed from DaVinci was never released.

cerebrl

I'd still like to remove the old protectsdk field from this as it is no longer relevant and removed from DaVinci, but this looks good otherwise.

ryanbas21 force-pushed the mock-api-routes branch from 50b93b6 to c731902 Compare August 8, 2025 17:26

ryanbas21 force-pushed the mock-api-routes branch from c731902 to 57e2e6b Compare August 12, 2025 17:36

cerebrl reviewed Aug 12, 2025

View reviewed changes

ryanbas21 marked this pull request as ready for review August 13, 2025 16:36

ryanbas21 force-pushed the mock-api-routes branch from d582832 to 4817b73 Compare August 13, 2025 16:40

cerebrl approved these changes Aug 14, 2025

View reviewed changes

ryanbas21 added 2 commits August 14, 2025 15:14

chore: update-routes

bb81839

chore: update-routes,fix-cookie,etc

73f522d

ryanbas21 force-pushed the mock-api-routes branch from 4817b73 to 73f522d Compare August 14, 2025 21:14

ryanbas21 merged commit 0ab715e into main Aug 14, 2025
4 checks passed

ryanbas21 deleted the mock-api-routes branch August 14, 2025 21:41

chore: update-routes #365

chore: update-routes #365

Uh oh!

Conversation

ryanbas21 commented Aug 7, 2025

JIRA Ticket

Description

Uh oh!

nx-cloud bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

Legend

Uh oh!

changeset-bot bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

cerebrl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cerebrl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

nx-cloud bot commented Aug 7, 2025 •

edited

Loading

codecov-commenter commented Aug 7, 2025 •

edited

Loading

github-actions bot commented Aug 7, 2025 •

edited

Loading

github-actions bot commented Aug 7, 2025 •

edited

Loading

changeset-bot bot commented Aug 8, 2025 •

edited

Loading