Skip to content

SDKS-4311: Remove Protect Marketplace support#371

Merged
ancheetah merged 1 commit into
mainfrom
SDKS-4311-remove-marketplace
Aug 27, 2025
Merged

SDKS-4311: Remove Protect Marketplace support#371
ancheetah merged 1 commit into
mainfrom
SDKS-4311-remove-marketplace

Conversation

@ancheetah

Copy link
Copy Markdown
Collaborator

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-4311

Description

Removes any code related to Protect Marketplace nodes and changes module resolution from Bundler to esnext

No changeset.

@changeset-bot

changeset-bot Bot commented Aug 19, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4248bd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 4248bd3

Command Status Duration Result
nx run-many -t build ✅ Succeeded <1s View ↗
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 32s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-27 18:18:02 UTC

@codecov-commenter

codecov-commenter commented Aug 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.47%. Comparing base (5e3c00d) to head (4248bd3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   55.47%   55.47%           
=======================================
  Files          32       32           
  Lines        2044     2044           
  Branches      340      340           
=======================================
  Hits         1134     1134           
  Misses        910      910           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Deployed a17fcb2 to https://ForgeRock.github.io/ping-javascript-sdk/pr-371/a17fcb2a7bfd949972a0e9063eb536683b16053e branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/protect - 150.1 KB (-2.2 KB, -1.5%)

➖ No Changes

@forgerock/oidc-client - 21.4 KB
@forgerock/davinci-client - 34.1 KB
@forgerock/sdk-utilities - 4.0 KB
@forgerock/device-client - 9.2 KB
@forgerock/sdk-types - 5.9 KB
@forgerock/iframe-manager - 2.4 KB
@forgerock/sdk-request-middleware - 4.4 KB
@forgerock/storage - 1.4 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/sdk-oidc - 2.7 KB


11 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

@ancheetah ancheetah requested review from cerebrl and ryanbas21 August 19, 2025 15:18
@ancheetah ancheetah force-pushed the SDKS-4311-remove-marketplace branch from 85c85ae to 4248bd3 Compare August 27, 2025 18:15
@ancheetah ancheetah merged commit 7176dd5 into main Aug 27, 2025
4 checks passed
@ancheetah ancheetah deleted the SDKS-4311-remove-marketplace branch August 27, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants