Skip to content

Fix Vite vulnerability#373

Merged
ancheetah merged 1 commit into
mainfrom
upgrade-vite
Aug 25, 2025
Merged

Fix Vite vulnerability#373
ancheetah merged 1 commit into
mainfrom
upgrade-vite

Conversation

@ancheetah
Copy link
Copy Markdown
Collaborator

@ancheetah ancheetah commented Aug 21, 2025

Fixes issue #360. Mend Security Check assessed that there was a vulnerability in vite v6.2.6. I've upgraded to v6.3.4 as advised here.

Note: Phone number field test has been skipped. It is failing due to a pre-fill country code feature flag being turned on.
https://pingidentity.slack.com/archives/GNFNZBFE3/p1755560007399209

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 21, 2025

⚠️ No Changeset found

Latest commit: 3e0b342

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Aug 21, 2025

View your CI Pipeline Execution ↗ for commit 3e0b342

Command Status Duration Result
nx run-many -t build ✅ Succeeded <1s View ↗
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 9s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-25 15:29:00 UTC

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.47%. Comparing base (c806452) to head (3e0b342).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   55.47%   55.47%           
=======================================
  Files          32       32           
  Lines        2044     2044           
  Branches      340      340           
=======================================
  Hits         1134     1134           
  Misses        910      910           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 21, 2025

Deployed 158bc51 to https://ForgeRock.github.io/ping-javascript-sdk/pr-373/158bc51444f09e90d94daae6ba736ad96b2a872d branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 21, 2025

📦 Bundle Size Analysis

📦 Bundle Size Analysis

➖ No Changes

@forgerock/protect - 152.3 KB
@forgerock/oidc-client - 21.4 KB
@forgerock/davinci-client - 34.1 KB
@forgerock/sdk-utilities - 4.0 KB
@forgerock/device-client - 9.2 KB
@forgerock/sdk-types - 5.9 KB
@forgerock/iframe-manager - 2.4 KB
@forgerock/sdk-request-middleware - 4.4 KB
@forgerock/storage - 1.4 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/sdk-oidc - 2.7 KB


11 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

@ancheetah ancheetah requested a review from ryanbas21 August 21, 2025 15:33
Comment thread e2e/davinci-suites/src/phone-number-field.test.ts
@ancheetah ancheetah merged commit 9c55ec4 into main Aug 25, 2025
4 checks passed
@ancheetah ancheetah deleted the upgrade-vite branch August 25, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants