Mock api updates2#377
Conversation
|
|
View your CI Pipeline Execution ↗ for commit cccb90d
☁️ Nx Cloud last updated this comment at |
|
Deployed b047e79 to https://ForgeRock.github.io/ping-javascript-sdk/pr-377/b047e791c6a73ca0491332609c1a244fa3f47dac branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis➖ No Changes➖ @forgerock/davinci-client - 34.1 KB 11 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
| 'code token', | ||
| 'code token id_token', | ||
| ], | ||
| response_modes_supported: ['pi.flow', 'query', 'fragment', 'form_post'], |
There was a problem hiding this comment.
We should ensure 'pi.flow' is only included as a supported mode if it's PingOne, but absent in PingAM.
There was a problem hiding this comment.
I think it would be a different route than this, wouldn't it?
There was a problem hiding this comment.
How do I mentally connect this to the route it's serving? Is this PingOne only wellknown endpoint? If so, I can't immediately identify it as such.
There was a problem hiding this comment.
Every handler has a name, I named this openid. I can be more explicit.
All these routes are PingOne specific right now. I haven't touched anything AIC.
the spec.ts file defines the route, name, and schemas for the route.
The handler is the implementation of it.
There was a problem hiding this comment.
Ah, okay. Since OIDC is a spec, and not server-specific, we'll want to discuss how we will differentiate the subtle differences and explicitly label them.
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
This looks good, but let's have a conversation about differentiating between PingAM and PingOne soon.
Removes the `acr_values` query parameter from the capabilities endpoint and instead passes the value in a cookie. This commit addresses the following acceptance criteria: - The `authorize` handler now sets the `acr_values` cookie. - The `capabilities` handler now reads the `acr_values` from the cookie. - The `CapabilitiesQueryParams` has been removed from the `capabilities` endpoint definition. This change makes the API more compliant with the documentation.
ryanbas21
force-pushed
the
mock-api-updates2
branch
from
0daddc7 to
cccb90d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 55.47% 55.47%
=======================================
Files 32 32
Lines 2044 2044
Branches 340 340
=======================================
Hits 1134 1134
Misses 910 910 🚀 New features to boost your workflow:
|
3 participants
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4264
https://pingidentity.atlassian.net/browse/SDKS-4266
Description
Adds userinfo routes, fixes the openid route so its more dynamic, adds touches up authorization routes. fix any issues as we progressed through the flow