Skip to content

chore: update-ci-for-self-healing #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbas21 merged 2 commits into from
Sep 3, 2025
Merged

chore: update-ci-for-self-healing #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a8638f
chore: update-ci-for-self-healing
ryanbas21 Sep 2, 2025
f70900f
fix(e2e): make oidc logout test more robust
ryanbas21 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": [
"ping-javascript-sdk",
"scratchpad",
"@forgerock/pingone-scripts",
"@forgerock/device-client",
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ jobs:

- run: pnpm exec nx-cloud record -- nx format:check
- run: pnpm exec nx affected -t build typecheck lint test e2e-ci
- run: npx nx-cloud fix-ci
if: always()

- uses: codecov/codecov-action@v5
with:
Expand Down
8 changes: 4 additions & 4 deletions e2e/oidc-suites/src/logout.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ test.describe('Logout tests', () => {

await page.getByLabel('User Name').fill(pingAmUsername);
await page.getByRole('textbox', { name: 'Password' }).fill(pingAmPassword);
const amNavigation = page.waitForURL('http://localhost:8443/ping-am/**');
await page.getByRole('button', { name: 'Next' }).click();

await page.waitForURL('http://localhost:8443/ping-am/**');
await amNavigation;
expect(page.url()).toContain('code');
expect(page.url()).toContain('state');
await expect(page.getByRole('button', { name: 'Login (Background)' })).toBeHidden();
Expand Down Expand Up @@ -74,9 +74,9 @@ test.describe('Logout tests', () => {

await page.getByLabel('Username').fill(pingOneUsername);
await page.getByRole('textbox', { name: 'Password' }).fill(pingOnePassword);
const p1Navigation = page.waitForURL('http://localhost:8443/ping-one/**');
await page.getByRole('button', { name: 'Sign On' }).click();

await page.waitForURL('http://localhost:8443/ping-one/**');
await p1Navigation;
expect(page.url()).toContain('code');
expect(page.url()).toContain('state');
await expect(page.getByRole('button', { name: 'Login (Background)' })).toBeHidden();
Expand Down
Loading