Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 22, 2025

This PR contains the following updates:

Package Change Age Confidence
jsdom 27.0.0 -> 27.0.1 age confidence

Release Notes

jsdom/jsdom (jsdom)

v27.0.1

Compare Source

  • Fixed some regressions in CSS selectors. Most such regression fixes were done in a minor update of a dependency, and thus available for all fresh installs of v27.0.0. However, one related to class="" attribute changes is only possible with a new version of jsdom. (asamuzaK)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

⚠️ No Changeset found

Latest commit: f4ebffa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Oct 22, 2025

View your CI Pipeline Execution ↗ for commit f4ebffa

Command Status Duration Result
nx run-many -t build ✅ Succeeded <1s View ↗
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 2m 58s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-23 00:36:13 UTC

nx-cloud[bot]

This comment was marked as outdated.

@renovate renovate bot force-pushed the renovate/jsdom-27.x branch from bdedba9 to ad994a6 Compare October 22, 2025 23:53
nx-cloud[bot]

This comment was marked as outdated.

@renovate renovate bot force-pushed the renovate/jsdom-27.x branch from ad994a6 to 391744e Compare October 23, 2025 00:08
Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

The pull request updates jsdom from 27.0.0 to 27.0.1 and its transitive dependency parse5 from 7.3.0 to 8.0.0. The failing task is a Playwright end-to-end test suite located at e2e/davinci-suites/src/phone-number-field.test.ts.

Error Analysis:
Both failing tests follow the same pattern:

  1. Navigate to the application
  2. Attempt to register a new user by filling out a registration form
  3. Expect to see a heading with text "Registration Complete" after clicking Continue
  4. The element is never found, causing the test to fail with a timeout
  5. The afterEach hook then fails because the user was never successfully created, so the cleanup cannot proceed

The key insight is that jsdom is a JavaScript-based DOM implementation used for unit testing in Node.js environments (typically with test runners like Vitest or Jest). Playwright tests, however, run in actual browser contexts (Chromium, Firefox, or WebKit), not jsdom. The test file shows Playwright's browser automation APIs (page.goto, page.getByRole, etc.), which execute against real browsers.

The jsdom dependency in package.json is used by other parts of the monorepo for unit tests that need DOM APIs without a browser. The version bump from 27.0.0 to 27.0.1 would only impact those unit tests, not the Playwright E2E tests.

The test failure indicates that the registration workflow in the actual application is not completing successfully - the "Registration Complete" heading never appears. This could be due to:

  • Backend API issues in the test environment
  • Database connectivity problems
  • Authentication service failures
  • Test data conflicts (user already exists)
  • Timing issues with the application's async operations
  • Infrastructure/network issues in the CI environment

Since the jsdom upgrade cannot affect Playwright tests that run in real browsers, and the tests are failing due to application behavior (missing UI elements), this is classified as an environment_state failure. The dependency change is coincidental to the test failures.

A code change would likely not resolve this issue, so no action was taken.

Nx CloudView in Nx Cloud ↗


🎓 To learn more about Self Healing CI, please visit nx.dev

@renovate renovate bot force-pushed the renovate/jsdom-27.x branch from 391744e to f4ebffa Compare October 23, 2025 00:31
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.05%. Comparing base (b2cb1b6) to head (f4ebffa).

❌ Your project status has failed because the head coverage (19.05%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   19.05%   19.05%           
=======================================
  Files         138      138           
  Lines       27477    27477           
  Branches      975      975           
=======================================
  Hits         5237     5237           
  Misses      22240    22240           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 23, 2025

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/davinci-client@448

@forgerock/oidc-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/oidc-client@448

@forgerock/protect

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/protect@448

@forgerock/sdk-types

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-types@448

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-utilities@448

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/iframe-manager@448

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-logger@448

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-oidc@448

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-request-middleware@448

@forgerock/storage

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/storage@448

commit: f4ebffa

@github-actions
Copy link
Contributor

Deployed 1acd371 to https://ForgeRock.github.io/ping-javascript-sdk/pr-448/1acd3715d26353af4b3d796e9f56a774d5893ddc branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions
Copy link
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/journey-client - 0.0 KB (-82.0 KB, -100.0%)

📊 Minor Changes

📈 @forgerock/journey-client - 82.0 KB (+0.0 KB)

➖ No Changes

@forgerock/device-client - 9.2 KB
@forgerock/oidc-client - 23.0 KB
@forgerock/protect - 150.1 KB
@forgerock/sdk-utilities - 7.5 KB
@forgerock/sdk-types - 8.0 KB
@forgerock/storage - 1.4 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/iframe-manager - 2.4 KB
@forgerock/sdk-request-middleware - 4.4 KB
@forgerock/sdk-oidc - 2.5 KB
@forgerock/davinci-client - 35.4 KB


13 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

@ryanbas21 ryanbas21 merged commit bd511a9 into main Oct 23, 2025
7 checks passed
@ryanbas21 ryanbas21 deleted the renovate/jsdom-27.x branch October 23, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants