feat: add-optional-query-params-to-start#7
Conversation
🦋 Changeset detectedLatest commit: 6ce29c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 6ce29c4.
☁️ Nx Cloud last updated this comment at |
ryanbas21
force-pushed
the
query-params-to-start
branch
from
07c344f to
6959be7
Compare
| const config: DaVinciConfig = { | ||
| clientId: '724ec718-c41c-4d51-98b0-84a583f450f9', | ||
| redirectUri: window.location.href, | ||
| redirectUri: window.location.origin + '/', |
There was a problem hiding this comment.
because i added query params to the testing, i just appended the '/' since it's stripped when using origin.
| }); | ||
|
|
||
| const node = await davinciClient.start(); | ||
| const qs = window.location.search; |
There was a problem hiding this comment.
logic so that we can pull query params dynamically in tests
| "exclude": ["src/**/*.spec.ts", "src/**/*.test.ts"], | ||
| "include": ["src/**/*.ts"] | ||
| "exclude": ["**/*.spec.ts", "**/*.test.ts"], | ||
| "include": ["./main.ts", "components/**/*.ts"] |
There was a problem hiding this comment.
was causing issues with module resolution not using Bundler since there is no src dir here
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "moduleResolution": "NodeNext", |
There was a problem hiding this comment.
i think this was me debugging but should be a noop since this affects test files.
| const accessToken = await page.locator('#accessTokenValue').innerText(); | ||
| await expect(accessToken).toBeTruthy(); | ||
| }); | ||
| test('ensure query params passed to start are sent off in authorize call', async ({ page }) => { |
There was a problem hiding this comment.
copy pasted above test, passed in a query param and then also added a few other query params from authorize specifically to make sure thats what we are testing
ryanbas21
force-pushed
the
query-params-to-start
branch
from
6959be7 to
239d016
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (15.38%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 45.73% 54.12% +8.39%
==========================================
Files 18 13 -5
Lines 2003 1637 -366
Branches 123 111 -12
==========================================
- Hits 916 886 -30
+ Misses 1087 751 -336
🚀 New features to boost your workflow:
|
ryanbas21
force-pushed
the
query-params-to-start
branch
from
239d016 to
dc96747
Compare
adds ability to add query parameters to the start call
ryanbas21
force-pushed
the
query-params-to-start
branch
from
dc96747 to
6ce29c4
Compare
3 participants
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-3647
Description
adds ability to add query parameters to the start call