Fix CI: Restore user's PiecewiseLinearFunction implementation after upstream merge#2
Closed
Fix CI: Restore user's PiecewiseLinearFunction implementation after upstream merge#2
Conversation
Copilot
AI
changed the title
[WIP] Introduce PyVRP commits into branch
Fix CI: Restore user's PiecewiseLinearFunction implementation after upstream merge
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging
pyvrp:mainreplaced the fork's customPiecewiseLinearFunctionimplementation with the upstream's incompatible version, breaking mypy, C++ compilation, and tests.Root Cause
The two PLF implementations are semantically incompatible:
is_zero()The upstream's
_pyvrp.pyistub required bothbreakpointsandsegmentsas mandatory args, soPiecewiseLinearFunction()inModel.pyfailed mypy. Without a default constructor, C++ compilation would also fail.Changes
pyvrp/cpp/PiecewiseLinearFunction.h— Restored fork's implementation: default zero constructor,isZero(), andn+1breakpoints /nsegments semantics with domain-checked evaluation:pyvrp/cpp/bindings.cpp— Restored PLF binding with default args ([min, max]/[(0,0)]) andis_zero()method; usepyvrp::Duration/pyvrp::Costtypes instead ofint64_tpyvrp/_pyvrp.pyi— Restored stub:breakpoints/segmentsoptional,is_zero() -> bool, types asintinstead ofnp.int64tests/test_PiecewiseLinearFunction.py— Replaced upstream tests (wrong semantics) with fork's tests covering domain checks,is_zero(), and correct n+1/n shape invariant🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.