Skip to content

Adding sideEffects: false to package.json #137

@neoncube2

Description

@neoncube2

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Feature Request

A while back, I asked to add "sideEffects": false to this package's package.json file, to enable better tree shaking: #136

Anyway, I've found another reason that it might make sense to add this flag, which is that without it, if this module is imported but unused, its code still gets bundled.

See my comment at eugenezinovyev/react-fontawesome-svg-icon#36 (comment) for a more detailed explanation.

I'd reopen #136, but it says I don't have permissions XD

Thanks :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions