Bugfix: support Object.create(null)#123
Merged
ryan-roemer merged 2 commits intomasterfrom Mar 16, 2023
Merged
Conversation
ryan-roemer
commented
Mar 14, 2023
|
|
||
| function equal(a, b) { | ||
| // START: fast-deep-equal es6/index.js 3.1.1 | ||
| // START: fast-deep-equal es6/index.js 3.1.3 |
Member
Author
There was a problem hiding this comment.
I validated there was no diff in the actual code from 3.1.1 to 3.1.3 so updating comment here.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 1 1
Lines 56 56
=======================================
Hits 55 55
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yankovalera
approved these changes
Mar 16, 2023
Member
Author
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object.create(null)to work without error. Fixes Cannot compare object will null prototype #64