Pass through all props in withLive HOC#63
Merged
Conversation
Contributor
Author
|
Actually I just saw that in the master branch after ErrorBoundary changes the HOC doesn't even work anymore. The "element" property is always the error boundary. |
kitten
changed the title
Contributor
|
Thanks for the fix! tbh I don't think I'm using the HOC in any of my personal projects, so I didn't notice this mistake.
That sounds unrelated? The HOC only passes on the context and the element is always wrapped in an error boundary component. The behaviour used to be different for React 15 though before a recent modification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48