Typings fix #60
Merged
Typings fix #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kitten
reviewed
Feb 22, 2018
| } | ||
|
|
||
| export type BaseAuthConfiguration = | ||
| | { |
There was a problem hiding this comment.
I'm pretty sure this was a style choice that @jevakallio introduced using an automated prettier format. Have you accidentally skipped our lint-staged formatting? https://github.com/FormidableLabs/react-native-app-auth/blob/master/package.json#L18-L19
Contributor
Author
There was a problem hiding this comment.
Ah ok, I see. Never seen it written like that, it reads like "nothing or this or that" to me so I was afraid if it wouldn't accept nothing the way it was. Hope that makes sense :D Anyways, I've reverted it. Rest should be good to go in.
| }; | ||
|
|
||
| export interface AuthConfiguration extends BaseAuthConfiguration { | ||
| export type AuthConfiguration = BaseAuthConfiguration & { |
kitten
approved these changes
Feb 23, 2018
kadikraman
approved these changes
Feb 23, 2018
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixed errors typescript was complaining about.