Skip to content

Typings fix #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2018
Merged

Typings fix #60

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00ffb54
Fixed typings
PeterKottas Feb 22, 2018
ebc6bfd
Extra 'OR' removed
PeterKottas Feb 22, 2018
46ac110
Reverted what was intentional, not in fact a bug
PeterKottas Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ export type BaseAuthConfiguration =
serviceConfiguration?: ServiceConfiguration;
};

export interface AuthConfiguration extends BaseAuthConfiguration {
export type AuthConfiguration = BaseAuthConfiguration & {
Copy link

@kitten kitten Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Good catch!

clientSecret?: string;
scopes: string[];
redirectUrl: string;
additionalParameters?: { [name: string]: string };
dangerouslyAllowInsecureHttpRequests?: boolean;
}
};

export interface AuthorizeResult {
accessToken: string;
Expand Down