chore: update example RN version #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalkerco
force-pushed
the
chore/update-example-RN-version
branch
from
d7da2f4 to
155da0b
Compare
manosim
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the example app to a more recent version, and fixes an issue that was causing the tests to fail on Android when using RN version 0.69.x.
Closes #119
I attempted to get the Android CI tests to run, but ran into issues with the Java Version emulator compatibility, so I've disabled the Android CI again for now so that we can fix the Android issues in the library as a priority. Android tests can be run locally for the time being.
I've tried to update to 0.70.1, but the tests fail to run on Android.
It seems that our current monkey patching method doesen’t work with RN 0.70.0.
I guess when we import React in Owl it’s a different React that the app gets (though I’ve checked the version of both and they are the same).
Looking at why-did-you-render for inspiration, and they get the user to add some init code to the very start of their app index.js file that inits the project and passes in React (Setup docs).
We may want to test out something similar. It would make the initial setup slightly more involved but would guarantee we are patching the correct instance of React. This would be a breaking change, unless we can find another way to get it to work.