-
Notifications
You must be signed in to change notification settings - Fork 29
Docs: deployment #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Docs: deployment #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manosim
approved these changes
Jan 10, 2022
Contributor
manosim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - exciting!
Member
Author
|
@manosim I'm getting a library/demo app visual regression failure that I'm guessing is completely unrelated to my docs changes after merging in latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready for review!
I've changed a little bit of the base url stuff in Docusaurus, but all appears to work in localdev and staging deploys. You can see current staging at: https://formidable-com-react-native-owl-staging-68.surge.sh/open-source/react-native-owl/
I've hooked up what should be all the correct work for our production deploy to AWS at
https://formidable.com/open-source/react-native-owlon merging tomain, but we'll just want to watch that as we go.@formidableamy note that we have a weird chicken-and-egg thing where we need to have the deploy of this project site right before a deploy of the related
formidable.comchanges.Work:
docs/*+website/*changes