Fix preventDefaultTouchmoveEvent and other props not propagating updates
#135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently different
propsobjects are sent togetHandlerson eachrender.In theory this is fine, but because of the way that
getHandlerssets up event listeners (such asonMovelisteners), thestate.propsobject that gets used by these listeners is actually fixed as an older value.In practice, what this means, is that if props like
preventDefaultTouchmoveEventchange on the fly, then the value ofstate.props.preventDefaultTouchmoveEventin theonMovecallback does not get the new value, and instead keeps the initial value sent through.This PR sets up an explicit
propsobject to be passed through - so that the object reference is the same everywhere, so that the callback handlers get the up to date prop values.