Typescript: no implicit any #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottrippey
force-pushed
the
typescript-noImplicitAny
branch
from
706d665 to
21f4348
Compare
carloskelly13
pushed a commit
that referenced
this pull request
Feb 14, 2022
* feature(typescript): enabled `noImplicitAny` and improved types all over * feature(typescript): tiny type improvements * feature(typescript): rollback mdast-zone upgrade (fails with jest) Co-authored-by: scottrippey <scott.william.rippey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow-up to the previous TS conversion, this PR enables the
noImplicitAnyflag, thus requiring all types to be defined.This required many more strong types to be added, but did NOT require any functional code changes.
A few of the more complex, external types have been explicitly typed
any.Type of Change
How Has This Been Tested?
Simply ensure code looks better, and CI passes.
External type defs have not been changed.