Added file writers to complete JSX/TSX deck generation. #1145
Conversation
|
It's going to add build time, but we should add "generate, install, and build" CI steps in a separate workflow in parallel for each CLI generate scenario (what the existing CLI does) |
|
@ryan-roemer Yeah we'd definitely want to continue ensuring the CI works for all of the 3 flows. I'm open to ideas on verifying the |
scottrippey
left a comment
scottrippey
left a comment
There was a problem hiding this comment.
Looks really great! Love the separation of the files and functions.
| }, | ||
| "peerDependencies": {}, | ||
| "devDependencies": { | ||
| "spectacle": "workspace:spectacle@*", |
There was a problem hiding this comment.
@carlos-kelly This is listed as a devDep, but it looks to me like it's being used as a runtime dependency ... does it somehow get "baked in"?
We could bring in spectacle as a prod dep just to know the latest version. Hopefully it'd get cached since post-CLI you'd install it again.
There was a problem hiding this comment.
If it's a runtime it will be included in the entire bin when we build this cli as runnable. We likely need to do a script to extract out the version number from the other package.json rather than some kind of cross-package dependency. @gksander and I were pondering this, but I'm really mixed if typing the version is easier. We do that on one-page today.
There was a problem hiding this comment.
Yeah I'm mixed too ... hard-coding it seems easy, but not as easy to maintain.
There was a problem hiding this comment.
PNPM should work just with a "normal" spectacle dependency. My understanding is the workspace: is only needed when theres a very customize setup that disables PNPM workspace inference (?)
There was a problem hiding this comment.
I think we likely drop this, feels a bit over-engineered to avoid typing in a version number.
There was a problem hiding this comment.
I think we do need to change this before publishing, because currently trying to run the CLI (outside this repo) I think will fail.
There was a problem hiding this comment.
Yup! the CLI is not ready to be published yet. We still need to build the interactive prompts. Just flags are working.
There was a problem hiding this comment.
If we just want an "up-to-date" version number, tools like changesets, etc. can just take care of keeping this current on version/publish and then we could even have the CLI read it's own package.json:devDependencies.spectacle to infer the correct version...
Description
Adds support for the JavaScript and TypeScript project generation to create a 2-slide deck.
A new feature is support out of the box for custom css and images via the webpack loaders. Some users like to style components with css and add local images.
Type of Change
Please delete options that are not relevant (including this descriptive text).