Infra: bandaid version release #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I filed #1156 to track the issue with
pnpm install --fix-lockfileand the short answer is: (1) it appears to be some bug, and (2) I don't know how to fix it easily.Fortunately,
pnpm installalone should generatepnpm-lock.yamlchanges that we need to re-commit at the end of changeset version, so I've just switched to that.Separately, I've removed all
workspace:prefixes for cross-projectspectacledependencies because (1) they are not needed and (2) the complicate examples / other projects release-wise and confusion-wise because they are PNPM dependent artifacts.