Infra: build create-spectacle examples #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-roemer
commented
Aug 4, 2022
ryan-roemer
changed the title
ryan-roemer
commented
Aug 8, 2022
ryan-roemer
commented
Aug 8, 2022
ryan-roemer
commented
Aug 8, 2022
ryan-roemer
commented
Aug 8, 2022
gksander
approved these changes
Aug 8, 2022
Contributor
gksander
left a comment
gksander
left a comment
There was a problem hiding this comment.
Looks great! I wonder if it makes sense to only run this on changes to packages/create-spectacle 🤔 I guess we can monitor and see how long this takes to run, and if it ends up being any sort of bottleneck for general PRs, we could split it out then.
carloskelly13
approved these changes
Aug 8, 2022
Contributor
carloskelly13
left a comment
carloskelly13
left a comment
There was a problem hiding this comment.
This is really great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core work:
Work along the way:
jestdependencies to monorepo root