Change prop from style to styles for table components
#463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, can't override style, can we merge this ? |
Contributor
|
Hey @mpeyper! Sorry for the delay. I'm taking over as maintainer for the project and will review this and merge or give feedback within the week. Thanks! |
ebrillhart
approved these changes
Aug 25, 2018
Contributor
ebrillhart
left a comment
ebrillhart
left a comment
There was a problem hiding this comment.
These changes look good - if you wouldn't mind fixing merge conflicts, that would be great!
Contributor
Author
|
I'll take a look later today |
Contributor
Author
|
Hey @ebrillhart, Sorry for the delay. The PR is now up to date with master. Have a good day 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the base props to set the
textAlignvalue of aTableItemcomponent, I discovered that it was not working. Investigating the issue, it seems that there was a missing 's' on thestylesprop being passed through to the underlying emotion component.I did a scan of the other components and found that
TableRowandTableHeaderwere also not passing the correct prop through.