Skip to content

Conversation

@aquibm
Copy link
Contributor

@aquibm aquibm commented Oct 25, 2018

Description

Fixes #559 by resetting viewed items when the user navigates to a slide using the overview feature.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Reproduced the issue using the example deck and the steps outlined in #559, tested manually after making the fix.

Checklist: (Feel free to delete this section upon completion)

  • My code follows the style guidelines of this project (I have run yarn prettier-fix && yarn lint)
    - [ ] I have added tests that prove my fix is effective or that my feature works I've updated snapshots to make sure the right props are being passed through, but there are no tests for the Overview component at the moment.
  • New and existing unit tests pass locally with my changes (I have run yarn test)
  • I have performed a self-review of my own code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • My changes generate no new warnings
    - [ ] Any dependent changes have been merged and published in downstream modules

Fixes FormidableLabs#559 by resetting viewed items when the user navigates to a slide using the overview feature.
@ebrillhart ebrillhart merged commit 5b0a219 into FormidableLabs:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong slide transition after using overview mode

2 participants