Fullscreen updates #628
Merged
Fullscreen updates #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrillhart
approved these changes
Dec 27, 2018
Contributor
ebrillhart
left a comment
ebrillhart
left a comment
There was a problem hiding this comment.
looks awesome, thanks Tegan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves visibility of the fullscreen button, adds a keyboard shortcut to toggle fullscreen (Alt/Option + F), and toggles the "expand" icon that represents going into fullscreen with a "collapse" icon that represents leaving fullscreen and going back to window mode.
Window Screenshot
Fullscreen Screenshot
Fixes #413
Type of Change
How Has This Been Tested?
Tested manually and through existing test suite.