Add typescript types #630
Merged
Add typescript types #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-roemer
reviewed
Dec 27, 2018
Member
ryan-roemer
left a comment
ryan-roemer
left a comment
There was a problem hiding this comment.
License changes, package.json and template LGTM!!!
I'm not familiar with the types, so not opining there 😛
Nice work @rawrmonstar !
ebrillhart
approved these changes
Dec 28, 2018
Contributor
ebrillhart
left a comment
ebrillhart
left a comment
There was a problem hiding this comment.
This LGTM, thanks Tegan!
kale-stew
approved these changes
Dec 28, 2018
This was referenced Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move TypeScript type definitions from DefinitelyTyped to this repo
Fixes #627
Type of Change
How Has This Been Tested?
Tested manually with a TypeScript CRA app.