(persisted-fetch) Replace js-sha256 polyfill for Node with Node's Crypto API#807
Merged
(persisted-fetch) Replace js-sha256 polyfill for Node with Node's Crypto API#807
Conversation
🦋 Changeset is good to goLatest commit: 3eef83a We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
fix/remove-polyfill-from-persisted
branch
from
1acd6dd to
0104316
Compare
As it turns out, the `crypto` global is only available in the REPL.
kitten
force-pushed
the
fix/remove-polyfill-from-persisted
branch
from
0104316 to
e5eb2f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We currently only require
js-sha256for Node.js, but instead we can rely on Node's Native Crypto API.This is being exposed as the
cryptoglobal seemingly, which makes an import/require ofcryptosuperfluous.Set of changes
js-sha256