(persisted) - Add generateHash option to the persistedFetchExchange#870
Merged
kitten merged 5 commits intourql-graphql:masterfrom Jun 18, 2020
Merged
(persisted) - Add generateHash option to the persistedFetchExchange#870kitten merged 5 commits intourql-graphql:masterfrom
kitten merged 5 commits intourql-graphql:masterfrom
Conversation
🦋 Changeset is good to goLatest commit: 861cc51 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jun 17, 2020
kitten
approved these changes
Jun 18, 2020
Member
kitten
left a comment
There was a problem hiding this comment.
Thanks for picking this up! We really haven’t had time to look into React Native support and different avenues, but seeing how simple this addition is it just makes more sense 👍
Member
|
Thanks again! This has now been published as |
Contributor
Author
|
Cool! Thank you both ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for a custom hash function in the persisted query exchange. This is useful for non-browser environments like react-native, where you might want to use a different crypto API (like Expo's, for instance).
Usage:
Set of changes
Adds an argument to the
persistedFetchExchangefactory. No breaking changes.