Skip to content

(persisted-fetch) - pass document as a second argument to the generateHash option#887

Merged
JoviDeCroock merged 4 commits intomainfrom
pass-document
Jun 30, 2020
Merged

(persisted-fetch) - pass document as a second argument to the generateHash option#887
JoviDeCroock merged 4 commits intomainfrom
pass-document

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Collaborator

@JoviDeCroock JoviDeCroock commented Jun 30, 2020

Summary

This passes the parsed GQL document as a second parameter so it can be used to get an already calculated hash.

Resolves #886

Set of changes

  • add Second document parameter to generateHash

@JoviDeCroock JoviDeCroock requested a review from kitten June 30, 2020 13:53
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 30, 2020

🦋 Changeset is good to go

Latest commit: 3a6ab4f

We got this.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-persisted-fetch Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock marked this pull request as ready for review June 30, 2020 14:05
@JoviDeCroock JoviDeCroock merged commit 1cdfbef into main Jun 30, 2020
@JoviDeCroock JoviDeCroock deleted the pass-document branch June 30, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Avoid persisted fetch queries hashing in the browser. Compile it at build time! ☺

2 participants