(populate) - support (nested) interfaces & unions in the return type#963
Merged
(populate) - support (nested) interfaces & unions in the return type#963
Conversation
JoviDeCroock
requested review from
andyrichardson,
kadikraman,
kitten and
wgolledge
🦋 Changeset detectedLatest commit: 97dbc16 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
changed the title
kadikraman
reviewed
Sep 8, 2020
kadikraman
reviewed
Sep 8, 2020
andyrichardson
approved these changes
Sep 29, 2020
Contributor
andyrichardson
left a comment
andyrichardson
left a comment
There was a problem hiding this comment.
Looks like a great addition!
* remove need for visit with typeinfo * simplify logic * simplify document logic * add todo * remove one visit * remove one visit * remove unused import * remove another visit * remove last visit * cleanup implementation * remove ts-ignore * cleanup implementation * Fix warning Co-authored-by: Phil Pluckthun <phil@kitten.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #909
Summary
Adds support for nested complex types