Conversation
- Add getPath prop to victory bar
- For non-polar charts, getPath expects a function ({ x0, x1, y0, y1}) -> string describing svg path
- For polar charts, getPath expects a function ({ datum, start, end, r1, r2 }) -> string describing svg path, where is an object of shape {x, y}, are angles derived from styles.width, and are the radii (top/bottom) of each polar bar
- Add stories to storybook demonstrating usage
boygirl
left a comment
There was a problem hiding this comment.
I would much prefer getPath to take a single argument props and have the same signature for polar and standard bars. To make it easier for folks, the props that we pass in can include all the pre-calculated values like width, startAngle and endAngle
|
Yeah I was definitely not sure about what variables to include in the I've changed the code so that FYI: I've added some stories to test the |
|
Also, your polar shooting stars look rad |
datumis an object of shape {x, y},start/endare angles derived from styles.width, andr1/r2are the radii (top/bottom) of each polar bar