Updated docs to make it more clear UseDataCollector is required in cs… #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
It is not required. As mentioned in the readme the collector driver is not suitable for all projects. Also it is not the only way to opt in to the collector driver.
What I will do is highlight in the readme the issues that can occur when not using the collector. Particularly the 0% coverage that you encountered. |
tonyhallett
added a commit
to tonyhallett/FineCodeCoverage
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted here:
#128 (reply in thread)
It was not clear I needed to set
<UseDataCollector/>in my csproj file and things weren't working.This PR just tweaks the README to make it more clear.