Skip to content

Conversation

@Aga-C
Copy link
Contributor

@Aga-C Aga-C commented Jul 3, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Used everywhere decimal and grouping separators taken from DecimalFormatSymbols.
  • Removed the old setting for choosing what formatting user want (as it was invalid in some cases, as I described in App doesn't follow locale number formatting #64).

Before/After Screenshots/Screen Record

Screenshot_6

Fixes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • All checks are passing.

@Aga-C Aga-C requested a review from naveensingh as a code owner July 3, 2025 07:19
@naveensingh
Copy link
Member

Updated lint and detekt configuration. The errors should go away once you merge main into this branch (or use the Update with rebase GitHub option).

Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two edge cases on locale change:

  • History items use the previous formatting. For example, the result in 10,5 + 5 = 15,5 becomes 155 when switching from Polish to English. Previously, history was being cleared when the comma was toggled (not ideal either).
  • The widget and the views still use the previous formatting.

Merging now, both of these can be handled later. Thank you.

@naveensingh naveensingh merged commit 9f06fc5 into FossifyOrg:main Jul 4, 2025
6 checks passed
@Aga-C Aga-C deleted the use-system-formatting branch July 4, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App doesn't follow locale number formatting

2 participants