Skip to content

feat: dialog for choosing contact source while editing merged contact (#201)#202

Merged
naveensingh merged 7 commits intoFossifyOrg:masterfrom
Aga-C:edit-non-messenger-contact
May 31, 2025
Merged

feat: dialog for choosing contact source while editing merged contact (#201)#202
naveensingh merged 7 commits intoFossifyOrg:masterfrom
Aga-C:edit-non-messenger-contact

Conversation

@Aga-C
Copy link
Contributor

@Aga-C Aga-C commented Jan 4, 2025

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

Fixes the following issue(s)

Acknowledgement

@naveensingh naveensingh self-assigned this May 26, 2025
@naveensingh
Copy link
Member

Yeah, let's go with a Choose contact to edit radio dialog. It'll be simpler that way.

@naveensingh
Copy link
Member

naveensingh commented May 31, 2025

You just couldn't let me skip this one, could ya? :)

Just three problems:

  • The dialog should not show up when tapping a contact source at the bottom of the view contact screen. It's implicit in that case.
  • The dialog should show up when Merge duplicate contacts is enabled and On contact click is set to Edit contact.
  • The radio button ripple effect is being clipped. Why not just reuse RadioGroupDialog here? See SimpleActivity.showContactSourcePicker for example.

@Aga-C Aga-C changed the title Ensure editing non-messenger contact while editing merged contact (#201) feat: dialog for choosing contact source while editing merged contact (#201) May 31, 2025
Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good now. Just made a change myself because I'm on a clock. Thanks!

@naveensingh naveensingh merged commit 3cbf38c into FossifyOrg:master May 31, 2025
3 of 5 checks passed
@Aga-C Aga-C deleted the edit-non-messenger-contact branch May 31, 2025 16:02
@fossifybot fossifybot bot added the released label May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Can display, but not edit, (birth)dates from old phone

2 participants